Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(flow): func spec api&use Error not EvalError in mfp #3657

Merged
merged 10 commits into from
Apr 9, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Apr 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

!!! DO NOT LEAVE THIS BLOCK EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Make some changes to various types to make them easy to use.

  • Summarize your change (mandatory)
    • refactor the functions for *Function to choose what specialized function to use when input types are known.
    • Also allow signature to have multiple input and refine defining signatures with macro
    • Use Error for MapFilterProject 's method that should only be called when building a dataflow graph
    • map, projection and filter for TypedPlan since they are commonly used in building those plan from substrait
    • some new methods for ColumnType

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 8, 2024
@discord9 discord9 mentioned this pull request Apr 8, 2024
19 tasks
@discord9 discord9 marked this pull request as ready for review April 8, 2024 03:11
@discord9 discord9 requested a review from zhongzc April 8, 2024 03:11
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 50.15674% with 159 lines in your changes are missing coverage. Please review.

Project coverage is 84.88%. Comparing base (183fccb) to head (9162796).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
- Coverage   85.16%   84.88%   -0.29%     
==========================================
  Files         949      950       +1     
  Lines      158673   158736      +63     
==========================================
- Hits       135131   134736     -395     
- Misses      23542    24000     +458     

src/flow/clippy.toml Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
src/flow/src/expr/func.rs Outdated Show resolved Hide resolved
@zhongzc zhongzc requested a review from waynexia April 8, 2024 09:01
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some style sugg.

src/flow/src/expr/id.rs Outdated Show resolved Hide resolved
src/flow/src/lib.rs Show resolved Hide resolved
src/flow/src/expr/relation/func.rs Outdated Show resolved Hide resolved
@tisonkun tisonkun added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@tisonkun tisonkun enabled auto-merge April 9, 2024 01:56
@killme2008
Copy link
Contributor

@discord9 There is a compile error.

@discord9
Copy link
Contributor Author

discord9 commented Apr 9, 2024

wired, will fix it soon

@tisonkun tisonkun added this pull request to the merge queue Apr 9, 2024
Merged via the queue into GreptimeTeam:main with commit ea9367f Apr 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants